Double quote to prevent globbing and word splitting

dappnode · Aug 14, 2024 · 8048ee0 · 8048ee0
1 parent 45db9d0
commit 8048ee0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/beacon-chain/entrypoint.sh b/beacon-chain/entrypoint.sh
@@ -34,22 +34,22 @@ if [ -n "$_DAPPNODE_GLOBAL_MEVBOOST_HOLESKY" ] && [ "$_DAPPNODE_GLOBAL_MEVBOOST_
     fi
 fi
 
-exec node --max-old-space-size=${MEMORY_LIMIT} /usr/app/node_modules/.bin/lodestar \
+exec node --max-old-space-size="${MEMORY_LIMIT}" /usr/app/node_modules/.bin/lodestar \
     beacon \
     --network=holesky \
-    --suggestedFeeRecipient=${FEE_RECIPIENT_ADDRESS} \
+    --suggestedFeeRecipient="${FEE_RECIPIENT_ADDRESS}" \
     --jwt-secret=/jwtsecret \
-    --execution.urls=$HTTP_ENGINE \
+    --execution.urls="${HTTP_ENGINE}" \
     --dataDir=/var/lib/data \
     --rest \
     --rest.address 0.0.0.0 \
-    --rest.port ${BEACON_API_PORT} \
-    --port $P2P_PORT \
+    --rest.port "${BEACON_API_PORT}" \
+    --port "${P2P_PORT}" \
     --metrics \
     --metrics.port 8008 \
     --metrics.address 0.0.0.0 \
     --logFile /var/lib/data/beacon.log \
-    --logLevel=${DEBUG_LEVEL} \
+    --logLevel="${DEBUG_LEVEL}" \
     --logFileLevel=debug \
     --logFileDailyRotate 5 \
-    $EXTRA_OPTS
+    "${EXTRA_OPTS}"
diff --git a/validator/entrypoint.sh b/validator/entrypoint.sh
@@ -15,7 +15,7 @@ LANG=$oLang LC_ALL=$oLcAll
 exec node /usr/app/node_modules/.bin/lodestar \
     validator \
     --network=holesky \
-    --suggestedFeeRecipient=${FEE_RECIPIENT_ADDRESS} \
+    --suggestedFeeRecipient="${FEE_RECIPIENT_ADDRESS}" \
     --graffiti="${graffitiString}" \
     --dataDir=/var/lib/data \
     --keymanager true \
@@ -25,12 +25,12 @@ exec node /usr/app/node_modules/.bin/lodestar \
     --metrics \
     --metrics.port 5064 \
     --metrics.address 0.0.0.0 \
-    --externalSigner.url=${HTTP_WEB3SIGNER} \
-    --doppelgangerProtection=${DOPPELGANGER_PROTECTION} \
-    --beaconNodes=${BEACON_NODE_ADDR} \
+    --externalSigner.url="${HTTP_WEB3SIGNER}" \
+    --doppelgangerProtection="${DOPPELGANGER_PROTECTION}" \
+    --beaconNodes="${BEACON_NODE_ADDR}" \
     --http.requestWireFormat=ssz \
-    --logLevel=${DEBUG_LEVEL} \
+    --logLevel="${DEBUG_LEVEL}" \
     --logFileLevel=debug \
     --logFileDailyRotate 5 \
     --logFile /var/lib/data/validator.log \
-    $EXTRA_OPTS
+    "${EXTRA_OPTS}"