Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra opts, add l1 rpc trust settings #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alexpeterson91
Copy link
Member

add L1 RPC trust to work with clients without storage proofs (i.e. Erigon) for local nodes and off for custom.

also fixed the custom L1 RPC env by fixing its entry in the compose file, should resolve the requirement to enter an extra custom RPC since now the variable is "" before it was undefined as anything.

also changed the extra_flags env variable to EXTRA_OPTS as everything else, and also made it work by adding it to the docker compose, the docker compose was/is formatted incorrectly.

some more flags likely to be added i.e. for P2P services ports, and flags etc. in another PR

@alexpeterson91 alexpeterson91 added the bug Something isn't working label Nov 28, 2023
@alexpeterson91 alexpeterson91 self-assigned this Nov 28, 2023
removed extra `.` in the l1 rpc trust flag
@alexpeterson91
Copy link
Member Author

Intended to make as a draft PR but cant due to current settings so please remember this is a DRAFT PR, and organization billing is at its limit so i cant use your CI and becuase forking is locked I cant use my organization's CI either which is what i prefer to do since ill use the CI to do a lot of my testing and dont wanna use up your credits. Regardless this fixed some things with OP-Node that never worked before but i still dont have it working properly i think it has something to do with the OP-Geth/OP-Erigon client. no longer gicing errors that there's no supported storage proofs. --l1.rpctrust=true was a needed parameter to cause that error to keep from happening. but this remains a draft PR just cant mark it as such right now.

@alexpeterson91
Copy link
Member Author

@dappnodedev sorry didnt mean to request a review just yet, i just cant open a draft PR on this repo ATM. but please take a look at it and see what you think, im quite sure some of the params if not all I added were/are needed, but i assume some others might be as well, as well as changes to the other packages it interacts with and for the dappmanager (because it wont allow the custom L1 RPC field to be empty even though it should be fine empty and default to the global_env for L1 RPC, but instead the dappamanger always rejects a blank L1 RPC field for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant