Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to introduce RPC endpoint during installation #1

Open
pablomendezroyo opened this issue Jun 22, 2021 · 1 comment
Open

Comments

@pablomendezroyo
Copy link
Contributor

pablomendezroyo commented Jun 22, 2021

Rotki allows users to introducethe RPC endpoint of its own ETH node to make the requests instead of using the default Etherscan API, this feature will:

  • Ensure user privacy
  • Makes requests faster

In the Rootki UI is possible to introduce the RPC endpoint:
image

Solution 1

Ideally this should be done during the installation process, asking the user to introduce its own RPC eth endpoint. Then modifying the docker image entrypoint: https://github.com/rotki/rotki/blob/6b84e27df5e953162d42a159e6729942bbe1719d/packaging/docker/docker-entrypoint.sh#L3

From --api-cors http://localhost:8080 to the user input (e.g geth endpoint selection)

To achieve this would be necessary a new dappmanager api endpoint to ask which ETH node is the "fullnode" set in the repository source: dappnode/DNP_DAPPMANAGER#824

Solution 2

Instead of create a new dappmanager api endpoint use the existing ones to determine if eth client is present:
geth > openethereum > nethermind > etc

@kelsos
Copy link
Contributor

kelsos commented Nov 1, 2022

We were discussing this rotki/rotki#4596 on how to achieve auto-configuration for RPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants