Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New http endpoint to expose the "fullNode" selected by the user #824

Closed
pablomendezroyo opened this issue Jun 22, 2021 · 3 comments · Fixed by #832
Closed

New http endpoint to expose the "fullNode" selected by the user #824

pablomendezroyo opened this issue Jun 22, 2021 · 3 comments · Fixed by #832

Comments

@pablomendezroyo
Copy link
Contributor

pablomendezroyo commented Jun 22, 2021 •
edited
Loading

User chooses between full node, remote and light client as one of the dappnode settings.

If selection is full Node then dappmanager should expose this choice as an API endpoint so other dappnode packages know which is the default RPC endpoint used by its dappnode.

An example of necessity is dappnode/DAppNodePackage-rotki#1
@pablomendezroyo pablomendezroyo mentioned this issue Jun 22, 2021
Open
@dapplion
Copy link
Contributor

Maybe we can expose the fullnode.dappnode target through GLOBAL_ENVS

@pablomendezroyo
Copy link
Contributor Author

Maybe we can expose the fullnode.dappnode target through GLOBAL_ENVS

sounds good

@pablomendezroyo pablomendezroyo linked a pull request Jun 29, 2021 that will close this issue
Add fullnode.dappnode domain to docker DNS #832
Merged
@pablomendezroyo
Copy link
Contributor Author

closed by #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fullnode.dappnode domain to docker DNS dappnode/DNP_DAPPMANAGER
2 participants
@dapplion @pablomendezroyo