Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullnode.dappnode domain to docker DNS #832

Merged
merged 11 commits into from
Jul 30, 2021
Merged

Add fullnode.dappnode domain to docker DNS #832

merged 11 commits into from
Jul 30, 2021

Conversation

pablomendezroyo
Copy link
Contributor

@pablomendezroyo pablomendezroyo commented Jun 29, 2021

According to the upcoming deletion of the BIND package and the switch to use the native docker DNS has been added the corresponding settings needed (alias fullnode.dappnode) to the fullnode feature.

  • Add migration to ethClient module:
  • Remove/add alias fullnode.dappnode in the compose when necessary
  • Disconnect/connect package to update the alias
  • Create new editor compose funcions: addAlias and removeAlias (might be necessary in the future since the alias will be the new endpoint used)
  • Remove unnecesary funcions
  • Add unit tests to compose editor

@pablomendezroyo pablomendezroyo added this to the v0.2.43 milestone Jun 29, 2021
@github-actions github-actions bot temporarily deployed to commit June 29, 2021 13:00 Inactive
@github-actions
Copy link

github-actions bot commented Jun 29, 2021

@github-actions
Copy link

github-actions bot commented Jun 29, 2021

DAppNode bot has built and pinned the release to an IPFS node, for commit: 5a941f2

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmXogAHmfn2v5nrhCASb6CnUdfcsNJUgx5ddxkd3h3fxtC

(by dappnodebot/build-action)

@dapplion
Copy link
Contributor

While this PR solves the issue with fullnode.dappnode it doesn't address the underlying issue where the logic to handle BIND mappings and docker DNS alias is duplicated. A long term sustainable solution would involve to merge those entities so whenever a consumer wants to manipulate domains it affects everything automatically.

@pablomendezroyo
Copy link
Contributor Author

While this PR solves the issue with fullnode.dappnode it doesn't address the underlying issue where the logic to handle BIND mappings and docker DNS alias is duplicated. A long term sustainable solution would involve to merge those entities so whenever a consumer wants to manipulate domains it affects everything automatically.

Should I think already on this, or open an issue for the near future

@dapplion
Copy link
Contributor

While this PR solves the issue with fullnode.dappnode it doesn't address the underlying issue where the logic to handle BIND mappings and docker DNS alias is duplicated. A long term sustainable solution would involve to merge those entities so whenever a consumer wants to manipulate domains it affects everything automatically.

Should I think already on this, or open an issue for the near future

The earliest we find a solution the less risk of having bugs like this

@github-actions github-actions bot temporarily deployed to commit June 30, 2021 11:44 Inactive
@github-actions github-actions bot temporarily deployed to commit June 30, 2021 17:02 Inactive
@github-actions github-actions bot temporarily deployed to commit June 30, 2021 23:17 Inactive
@dapplion dapplion changed the title Fullnode integration with native docker BIND Add fullnode.dappnode domain to docker DNS Jul 1, 2021
@github-actions github-actions bot temporarily deployed to commit July 1, 2021 12:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fullnode.dappnode not set propertly New http endpoint to expose the "fullNode" selected by the user
2 participants