-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fullnode.dappnode domain to docker DNS #832
Conversation
DAppNode bot has built and pinned the release to an IPFS node, for commit: 5a941f2 This is a development version and should only be installed for testing purposes, install link
(by dappnodebot/build-action) |
packages/dappmanager/src/modules/ethClient/changeEthMultiClient.ts
Outdated
Show resolved
Hide resolved
packages/dappmanager/src/modules/ethClient/changeEthMultiClient.ts
Outdated
Show resolved
Hide resolved
packages/dappmanager/src/modules/ethClient/changeEthMultiClient.ts
Outdated
Show resolved
Hide resolved
packages/dappmanager/src/modules/ethClient/changeEthMultiClient.ts
Outdated
Show resolved
Hide resolved
packages/dappmanager/src/modules/ethClient/changeEthMultiClient.ts
Outdated
Show resolved
Hide resolved
While this PR solves the issue with fullnode.dappnode it doesn't address the underlying issue where the logic to handle BIND mappings and docker DNS alias is duplicated. A long term sustainable solution would involve to merge those entities so whenever a consumer wants to manipulate domains it affects everything automatically. |
Should I think already on this, or open an issue for the near future |
The earliest we find a solution the less risk of having bugs like this |
According to the upcoming deletion of the BIND package and the switch to use the native docker DNS has been added the corresponding settings needed (alias
fullnode.dappnode
) to the fullnode feature.ethClient
module:fullnode.dappnode
in the compose when necessary