Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support invokeXXX return Response #755

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

support invokeXXX return Response #755

wants to merge 20 commits into from
+363 −83

Conversation

naah69
Copy link

@naah69 naah69 commented Jun 27, 2022

Description

add DaprResponse interface and HttpDaprResponse,GrpcDaprRespnse implement.

Issue reference

#751

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@naah69 naah69 requested review from a team as code owners June 27, 2022 06:43
@tanvigour
Copy link
Contributor

Please resolve the conflicts

@naah69
Copy link
Author

naah69 commented Jun 29, 2022

Please resolve the conflicts

it had resolved.

artursouza and others added 17 commits July 7, 2022 13:57
@artursouza @naah69
Release 1.5.0-rc-1
697aecf 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@mukundansundar @tanvigour @naah69
Test long vals (dapr#717)
762022d 
* run IT test for long values

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* Fix the class name

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* assert for all messages and fix class name

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* test for Long.MAX_VALUE

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* revert back long number and print

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* fix the typo

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* update the latest dapr commit in workflow files

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* log some more data to debug

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* debug

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* get the value from messages

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* fix long values assert

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* increasing TTL

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

Co-authored-by: tanvigour <tanvi.gour@gmail.com>
Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@artursouza @naah69
Upgrade version to 1.5.0
3341457 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@artursouza @naah69
Generate updated javadocs for 1.5.0
94372c9 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@mukundansundar @naah69
fix dapr runtime,cli as 1.7.0-rc.3 (dapr#728)
816ca3a 
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@naah69
add response interface and http,grpc implement
287b196 
Signed-off-by: naah69 <nayan3480232@163.com>
@artursouza @naah69
Upgrade the version to 1.6.0-SNAPSHOT (dapr#727)
9f1ad8f 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
@dependabot @naah69
Bump actions/setup-go from 2 to 3 (dapr#731)
aeede82 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@shubham1172 @naah69
Pin fossa-action version (dapr#734)
2fc8df9 
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@fackee @mukundansundar @naah69
replace vault to local (dapr#719)
4dcf90a 
* replace vault to local

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* change secret store name style

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* delete vault token file

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* remove vault int validate.yml

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* fix it secret case

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* replace vault to local

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* change secret store name style

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* delete vault token file

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* remove vault int validate.yml

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* fix it secret case

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* fix it dead loop

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

Co-authored-by: zjx244729 <zjx244729@alibaba-inc.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@dependabot @naah69
Bump fossas/fossa-action from 1.1.0 to 1.3.1 (dapr#737)
efffd64 
Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.1.0 to 1.3.1.
- [Release notes](https://github.com/fossas/fossa-action/releases)
- [Commits](fossas/fossa-action@v1.1.0...v1.3.1)

---
updated-dependencies:
- dependency-name: fossas/fossa-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@dependabot @naah69
Bump codecov/codecov-action from 2.1.0 to 3.1.0 (dapr#735)
1e797c1 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.1.0 to 3.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.1.0...v3.1.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@hhunter-ms @naah69
typo fix (dapr#742)
24dd4db 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@artursouza @naah69
Fix integration tests on Windows. (dapr#750)
704fc20 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@pkedy @mukundansundar
@artursouza @naah69
Adding pubsub routing support (dapr#631)
6358b27 
* Adding pubsub routing support

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* remove deprecated classes (dapr#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Address PR comments.

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@artursouza @naah69
Upgrade the version to 1.7.0-SNAPSHOT (dapr#753)
588bbfc 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>
@naah69
DaprResponse support bytes[]
5e47e1f 
Signed-off-by: naah69 <nayan3480232@163.com>
@naah69
Merge branch 'master' into response
d01064b 
Signed-off-by: Naah <nayan3480232@163.com>
artursouza
artursouza requested changes Jul 8, 2022
View reviewed changes
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not support invoke via gRPC anymore. Only HTTP. Please, change this PR to make the invoke method to be over HTTP only - you can use the PreviewClient interface for that.

@naah69
Copy link
Author

naah69 commented Jul 10, 2022

change

ok i will change it .

@mukundansundar
Copy link
Contributor

@skyao Can you review this PR?

naah69 added 2 commits July 21, 2022 19:48
@naah69
Merge branch 'dapr:master' into response
8baeefe
@naah69
Upgrade the version to 1.6.0-SNAPSHOT (dapr#727)
09a8878 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: naah69 <nayan3480232@163.com>

# Conflicts:
#	examples/pom.xml
#	pom.xml
#	sdk-actors/pom.xml
#	sdk-autogen/pom.xml
#	sdk-springboot/pom.xml
#	sdk-tests/pom.xml
#	sdk/pom.xml
naah69
naah69 commented Jul 22, 2022
View reviewed changes
Copy link
Author

@naah69 naah69 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it had changed.
@artursouza

@naah69 naah69 requested a review from artursouza July 22, 2022 02:52
naah69
naah69 commented Jul 22, 2022
View reviewed changes
Copy link
Author

@naah69 naah69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it changed

naah69
naah69 commented Jul 22, 2022
View reviewed changes
Copy link
Author

@naah69 naah69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

@naah69
Copy link
Author

naah69 commented Aug 8, 2022

any progress?

@mukundansundar
Copy link
Contributor

@naah69 Can you please fix the conflicts in the PR?

@cicoyle
Copy link
Contributor

cicoyle commented Feb 19, 2024

gentle ping @naah69

1 similar comment
@cicoyle
Copy link
Contributor

cicoyle commented Jun 19, 2024

gentle ping @naah69

@imerljak
Copy link

Is this still alive? Would be really nice to have it in order to get proper response status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artursouza artursouza Awaiting requested review from artursouza

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@naah69 @tanvigour @mukundansundar @cicoyle @imerljak @artursouza @shubham1172 @fackee @hhunter-ms @pkedy