Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve attestation creation errors and improve UX #162

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

daqhris
Copy link
Owner

@daqhris daqhris commented Nov 15, 2024

This PR addresses the attestation creation issues in the final stage of the enrollment process by:

  • Adding proper TypeScript types for transaction handling
  • Improving error handling with specific messages
  • Adding transaction confirmation and event parsing
  • Fixing network switching validation
  • Restoring NetworkSwitchButton component
  • Updating EAS contract address

These changes improve the user experience by:

  • Providing clear feedback during network switching
  • Showing proper error messages
  • Adding attestation preview functionality
  • Ensuring proper transaction handling

Testing:

  • Verified network switching to Base Sepolia
  • Tested attestation creation flow
  • Confirmed error handling scenarios

- Update EAS contract address to match constants.ts
- Standardize attestation schema across components
- Update schema encoding in EnrollmentAttestation.tsx
- Fix contract address in types/index.ts
- Add attestation preview functionality
- Add transaction hash display with BaseScan link
- Implement two-step process (Preview then Create)
- Improve button states and error handling
- Add better user feedback throughout process
- Add proper TypeScript types for transaction receipt and logs
- Improve error handling with specific messages
- Add transaction confirmation and event parsing
- Fix network switching validation
- Restore NetworkSwitchButton import
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mission-enrollment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 10:58am

@daqhris daqhris changed the title fix: Resolve attestation creation errors and improve user experience fix: Resolve attestation creation errors and improve UX Nov 15, 2024
@daqhris daqhris merged commit 616e0d9 into main Nov 15, 2024
3 of 4 checks passed
@daqhris daqhris deleted the fix/attestation-error branch November 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant