Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function(s) to locate function definitions in R scripts. #19

Merged
merged 6 commits into from
Feb 4, 2024

Conversation

Smit-tay
Copy link
Collaborator

@Smit-tay Smit-tay commented Feb 4, 2024

#7
This code is relatively untested, and really needs a much more robust set of example functions to parse
please consider adding to "example_scripts/example_tricky_functions.R"

if (length(less_than_value) == 0) {
return(value)
return (min(vector))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This element could be greater than the value, so should probably return NA here.

Copy link
Contributor

@RobertASmith RobertASmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, passes for me locally too.

@RobertASmith RobertASmith merged commit 8518799 into dark-peak-analytics:main Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants