Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests on the check_markov_trace function #4

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add additional tests on the check_markov_trace function #4

merged 2 commits into from
Jan 16, 2024

Conversation

RobertASmith
Copy link
Contributor

Added additional tests on the check_markov_trace function which increase code coverage.

As a result added some additional functionality to the function:

  • check for duplicate column names
  • add error message for increasing dead state.
  • stop (rather than warn) for non-numeric values. This is done because all other checks fail if non-numeric values

Smit-tay
Smit-tay approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@Smit-tay Smit-tay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement in code coverage within check_markov_trace

@RobertASmith RobertASmith merged commit be579d0 into main Jan 16, 2024
6 checks passed
@RobertASmith RobertASmith deleted the RS_trace_covr branch January 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smit-tay Smit-tay Smit-tay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertASmith @Smit-tay