Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change form.onsubmit to eventlistener #666

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iamkhush
Copy link

@iamkhush iamkhush commented Mar 9, 2018

In our usecase, we have another library that overloads form.onsubmit, and submits the form. However, the formIsDirty is also true ( because of the changes to Django Multiple Select Box ) and hence the confirmation pops up.
In the proposed change, Django suit would work together nicely with other libraries.

In our usecase, we have another library that overloads form.onsubmit, and submits the form. However, the `formIsDirty` is also true ( because of the changes to Django Multiple Select Box ) and hence the confirmation pops up. 
In the proposed change, Django suit would work together nicely with other libaries.
@codingjoe
Copy link

@iamkhush wouldn't it be also a good idea to make the same change on django-s3file?

@codingjoe
Copy link

codingjoe commented Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants