Skip to content

Commit

Permalink
Revert "dt_imageio_open_rawspeed(): always calculate black areas"
Browse files Browse the repository at this point in the history
Fixes #16815.
Refs. darktable-org/rawspeed#717.

This reverts commit 048ccc8.
  • Loading branch information
LebedevRI committed May 18, 2024
1 parent c66954f commit 895f595
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/imageio/imageio_rawspeed.cc
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ dt_imageio_retval_t dt_imageio_open_rawspeed(dt_image_t *img,
img->raw_black_level = r->blackLevel;
img->raw_white_point = r->whitePoint.value_or((1U << 16)-1);

if(!r->blackAreas.empty() || !r->blackLevelSeparate)
// NOTE: while it makes sense to always sample black areas when they exist,
// black area handling is broken in rawspeed, so don't do that for now.
// https://github.com/darktable-org/rawspeed/issues/389
if(!r->blackLevelSeparate)
{
r->calculateBlackAreas();
}
Expand Down

0 comments on commit 895f595

Please sign in to comment.