Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checking for exiftool at build time #16708

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Apr 29, 2024

It's not actually used for anything during the build.

The script is useful and should always be installed, exiftool could always be added later.

@kmilos kmilos force-pushed the kmilos/rm_exiftool_check branch from 12971c1 to 378ae5d Compare April 29, 2024 12:09
@TurboGit TurboGit added this to the 4.8 milestone Apr 29, 2024
@TurboGit TurboGit added the scope: codebase making darktable source code easier to manage label Apr 29, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@TurboGit TurboGit merged commit f8000c1 into darktable-org:master Apr 29, 2024
6 checks passed
@kmilos kmilos deleted the kmilos/rm_exiftool_check branch April 29, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants