Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename canvas enlargement -> enlarge canvas #16816

Merged
merged 1 commit into from
May 18, 2024

Conversation

elstoc
Copy link
Contributor

@elstoc elstoc commented May 18, 2024

The current naming is completely inconsistent with how the rest of the modules are named in darktable

@elstoc elstoc changed the title Rename the canvas enlargement -> enlarge canvas Rename canvas enlargement -> enlarge canvas May 18, 2024
@elstoc
Copy link
Contributor Author

elstoc commented May 18, 2024

To illustrate, if we wanted other modules to be named the same way then we'd have to have, for example "exposure adjustment", "image retouching", "tone equalizing".

In fact, to make it consistent with other modules, "enlarge" or "extend" might even be better

@elstoc elstoc requested a review from victoryforce May 18, 2024 15:38
@victoryforce
Copy link
Collaborator

First of all, I am not a native speaker, so my point of view on language issues is still secondary. I don't have a native sense of the language, only an understanding of grammar. Well, I totally agree that the word "enlargement" looks rather... out of style, let's say.

To illustrate, if we wanted other modules to be named the same way then we'd have to have, for example "exposure adjustment", "image retouching", "tone equalizing".

My argument for "enlargement" instead of "enlarge" was precisely to be closer to the way the vast majority of other modules are named (that is, without describing the action with the use of a verb). If we wanted other modules to be named the same way as "enlarge canvas" then we'd have to have "equalize tone", "calibrate color", "correct lens", "remove haze"...

But, this is just my humble comment on the issues of consistency of names, I think it is better for native speakers to decide on this issue.

@TurboGit TurboGit added this to the 4.8 milestone May 18, 2024
@TurboGit TurboGit added scope: translation / strings make darktable international bugfix pull request fixing a bug labels May 18, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit c66954f into darktable-org:master May 18, 2024
6 checks passed
@elstoc
Copy link
Contributor Author

elstoc commented May 18, 2024

If we wanted other modules to be named the same way as "enlarge canvas" then we'd have to have "equalize tone", "calibrate color", "correct lens", "remove haze"...

I do agree. "Enlarge" or "extend" would be more in keeping with other modules, but feel like that is maybe a bit too non-obvious (could be maybe misinterpreted). TBH there isn't all that much consistency anyway, but I think, for the moment, that "enlarge canvas" is just a bit less wrong.

(e.g. "filmic rgb" and "tone equalizer" aren't consistent with each other either)

HSUfineprint added a commit to HSUfineprint/darktable that referenced this pull request May 20, 2024
darktable-org#16816 made the module name the same with module description. That caused some problems for zh_TW translation. I just added some description.
TurboGit pushed a commit that referenced this pull request May 20, 2024
#16816 made the module name the same with module description. That caused some problems for zh_TW translation. I just added some description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug scope: translation / strings make darktable international
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants