A few OpenCL fixes #18065
Open
A few OpenCL fixes #18065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In globaltonemap the OpenCL code was most likely disabled as we checked for micro_nap instead of avoid_atomics 2. Included dt_iop_nap in dt_opencl_micro_nap(), it's api has changed to `void dt_opencl_micro_nap(const int devid)` 3. In atrous we didn't properly check for the per-device nap 4. Corrected a few OpenCL error codes
jenshannoschwalm
added
priority: low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void dt_opencl_micro_nap(const int devid)Would also be safe for 5.0 branch but certainly not required for stability, globaltonemap is not used often and atrous is only affected in case you have multiple devices.
Nothing worth to mention in release notes i think.