fix crash with variable SEQUENCE[n,m] #18106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dterrahe
reviewed
Dec 29, 2024
- remove non thread-safe strok() - simplify the code because we only have [n] ($(IMAGE_ID[4])) or [n,m] ($(SEQUENCE[4,1])). This can easily be extended if there is more needed in the future
zisoft
force-pushed
the
fix-variables
branch
from
f5338aa to
cdb6e61
Compare
|
TurboGit
added
priority: high
|
Merged in master and 5.0.x branch. |
|
Release notes: Fixed a crash in variable expansion for $(SEQUENCE[n,m]) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18100
The problem here is that a single-allocated string is handled as a two-field array where each element is released with
g_free(), which of course crashes.