fix crash in lens correction module due to accessing an unref'ed widget #18116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
added
bugfix
|
Why even have |
|
Yeah, that had occurred to me as I was testing the fix, but I wanted to stick to minimal and localized changes for 5.0.1. I can do the cleanup either as a separate PR for 5.2 or as an additional commit on this one. Pascal? |
Yes, works for me this way. |
|
Merged in master and 5.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to crash master:
The crash proved to be due to the model menu being unref'ed when closed and the next call then trying to destroy the unref'ed widget before recreating the menu hierarchy.