[RFC] move blending drawing shapes to match retouch #8376
Conversation
|
|
|
FYI this doesn't work with github's dark mode - the labels on the vote don't show up. Works fine if I switch back to light mode. |
Labels do show up, however it's dark gray against dark bueish-something quite desaturated colour so barely visible ;) Thanks for splitting this. Voted for "prefer consistency this pr gives" :) |
|
Sorry for that but I don't think I can do anything about it. The poll is generated by https://app.gh-polls.com. |
Ah ok - I see a bug has already been raised apex/gh-polls#47 but the repo doesn't seem to be very active so I won't expect anything. |
|
Is it too early to call this? "I hate this!" could make a strong comeback but it does look unlikely at this point. Then again, polls have been wrong before! |
|
I voted and I do believe this vote thingy doesn't work right.... Vote was 17 when I voted, browser kept going back and forward after my vote (the auto-redirect, I do believe about 5-6 times), then there was an error. I reloaded this page myself and the counter showed 23. These results might/are not very trustworthy! |
|
Maybe but nobody has voted "no" yet so that's good enough for me |
|
@elstoc : There you go. This vote thing is really, really bad. I was just able to vote a second time. And again it did this back-and-forth thing. All in all I voted 10 times now.... I'll refrain from f*cking it up any further.... |
|
So maybe a simple thumbs up/down would have been better 😀 |
That doesn't work either. :-) |
Nah you've just turned your vote into a "don't care" |
|
@jade-nl : of course it is always possible to break things, but well maybe with some wisdom we can work all together! |
|
@TurboGit : Don't get me wrong, I did not mean to joke around or deliberately mess up this poll! Just wanted to raise awareness about this particular tool not at all being up to specs to do what it was made for: I was able to vote twice (not good) and the counters jumped 10 votes (6+4), also not good. |
|
What is strange is that I cannot vote multiple time and the doc says that there is a single vote per IP counted. So do you have an IP changing all the time ? |
|
There might be multiple voters at the same time as I published link to this pr on IRC on #darktable and #pixls.us ... |
|
@TurboGit : No, I'm on a fixed IP. If you want me to I can try voting again, both yes and no if needed. @johnny-bit : That is what I initially thought. But it is rather strange that the yes count jumped 6 right after the back-and-forth and, about 10 minutes later the same thing happened, well 4 instead of 6, when voting no (which I shouldn't be able to do in the first place) |
|
These polls seem more trouble than they are worth. A simple thumb up or thumb down on the OP works too (and the names are visible; you can even change your vote which seems a benefit too in case of more complicated issues where insights might change after discussion). This particular change at least wasn't worth all this hassle... |
👍, 😄, ❤️, 🚀, 🎉 - as yes probably works |
|
Now thinking more about this the other option would be to invert retouch module only. This won't change habit for most people as blending (available in all modules) is certainly far more used than retouch. |
|
Personally I prefer the order in this PR to the one in the current blend modes. I'm happy to adapt my muscle-memory. |
|
I only now realised that it is actually possible on github to unsubscribe from your own PR! ;-) (Not to sound bitter or anything, and I mean that, I'm just joking, but this spin-off from another PR that took a few minutes to submit and that I don't really care about has had more response than #8078 which took a year of thinking and months of implementation. I'm not really worried though, because I'm sure the moment I change it from draft status everybody will suddenly have an opinion and expect me to change everything.) |
|
@dterrahe : Yes :) That's the way it is, the number of comments are usually inversely proportional to the difficulty of the subject. Anyway, I'll merge this now. Thanks. |
elstoc
added
documentation-complete
As suggested by @TurboGit split off from #8359 as it could be an unwanted change for some, but we like the consistency.
Old:
New:
Please vote below.