Merge pull request wildfly#18251 from scottmarlow/appclient_errorhand…

…ling [WFLY-19793] App client container should log java.lang.NoClassDefFoundError failures and other failures while loading the appclient main class
darranl · Sep 30, 2024 · 311daf6 · 311daf6
2 parents 5450b58 + 55dfef1
commit 311daf6
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/...t/src/main/java/org/jboss/as/appclient/deployment/ApplicationClientManifestProcessor.java b/...t/src/main/java/org/jboss/as/appclient/deployment/ApplicationClientManifestProcessor.java
@@ -45,23 +45,24 @@ public void deploy(final DeploymentPhaseContext phaseContext) throws DeploymentU
             if (main != null) {
                 String mainClass = main.getValue("Main-Class");
                 if (mainClass != null && !mainClass.isEmpty()) {
+                    final Class<?> clazz;
                     try {
-                        final Class<?> clazz = module.getClassLoader().loadClass(mainClass);
-                        deploymentUnit.putAttachment(AppClientAttachments.MAIN_CLASS, clazz);
-                        final ApplicationClientComponentDescription description = new ApplicationClientComponentDescription(clazz.getName(), moduleDescription, deploymentUnit.getServiceName());
-                        moduleDescription.addComponent(description);
-                        deploymentUnit.putAttachment(AppClientAttachments.APPLICATION_CLIENT_COMPONENT, description);
-
-                        final DeploymentDescriptorEnvironment environment = deploymentUnit.getAttachment(org.jboss.as.ee.component.Attachments.MODULE_DEPLOYMENT_DESCRIPTOR_ENVIRONMENT);
-                        if (environment != null) {
-                            DescriptorEnvironmentLifecycleMethodProcessor.handleMethods(environment, moduleDescription, mainClass);
-                        }
-                    } catch (ClassNotFoundException e) {
+                        clazz = module.getClassLoader().loadClass(mainClass);
+                    } catch (Throwable e) {
                         throw AppClientLogger.ROOT_LOGGER.cannotLoadAppClientMainClass(e);
                     }
+                    deploymentUnit.putAttachment(AppClientAttachments.MAIN_CLASS, clazz);
+                    final ApplicationClientComponentDescription description = new ApplicationClientComponentDescription(clazz.getName(), moduleDescription, deploymentUnit.getServiceName());
+                    moduleDescription.addComponent(description);
+                    deploymentUnit.putAttachment(AppClientAttachments.APPLICATION_CLIENT_COMPONENT, description);
 
+                    final DeploymentDescriptorEnvironment environment = deploymentUnit.getAttachment(org.jboss.as.ee.component.Attachments.MODULE_DEPLOYMENT_DESCRIPTOR_ENVIRONMENT);
+                    if (environment != null) {
+                        DescriptorEnvironmentLifecycleMethodProcessor.handleMethods(environment, moduleDescription, mainClass);
+                    }
                 }
             }
         }
     }
 }
+