add support for passphrase protected seeds #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is missing NFKD normalization of the passphrase, but should work for ascii |
|
Yes, Dart currently don't have builtin NFKD normalization package and https://github.com/yshrsmz/unorm-dart is having some problem so i leave multi-language feature as it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to bip-0039 seeds can be protected with a passphrase. However this package hardcodes the passphrase to '' (empty string).
This change adds a
passphraseparameter tomnemonicToSeedandmnemonicToSeedHexso it can be set to other values.Also added a test vector from the page linked in the spec .