-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conformance testing #706
Conversation
PR HealthPackage publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). |
.github/workflows/conformance.yml
Outdated
|
||
- uses: actions/checkout@7739b9ba2efcda9dde65ad1e3c2dbe65b41dfba7 | ||
with: | ||
repository: mosuem/conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to unicode/conformance
with ref main
as soon as makeScriptConfigurable
is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; the main question is which technique we'd prefer for checking again the expected test results - uploading a status file or having one committed to the repo
continue-on-error: true | ||
uses: actions/download-artifact@e9ef242655d12993efdcda9058dee2db83a2cb9b | ||
with: | ||
name: referenceExecSummary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this referenceExecSummary file look like? Is is human readable?
You might consider (in this PR or a following one) having a test status file checked into the repo. The CI would then fail if the test results didn't match what was in the file. People fixing tests (or adding new, failing tests) would then need to update the status file as part of their PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just the output folder of generateDataAndRun.sh
, which contains basically a bunch of JSON files and a HTML view. So it is human readable.
The file might be nice, but I don't know how this would work with the branch protection on the main
branch.
Add a workflow for https://github.com/unicode-org/conformance/ testing. This runs the conformance test suite with a custom configuration file, and compares the result against a previous run from the main branch. It fails if more tests are failing then were failing before.
FYI: @sven-oly @echeran
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.