Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt package:messages to be loading mechanism independent #843

Merged
merged 44 commits into from
Oct 31, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented May 27, 2024

  • Stop using build_runner in favor of dart run messages
  • Make loading injectable again, to be independent of the progress of dart:asset
  • Add Flutter examples
  • Fix a few small bugs (such as zero not being parsed)

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem changed the base branch from main to updateIntl4x May 27, 2024 11:13
@mosuem mosuem changed the base branch from updateIntl4x to main May 27, 2024 11:45
@dart-lang dart-lang deleted a comment from github-actions bot May 27, 2024
@mosuem mosuem changed the base branch from main to updateIntl4x May 27, 2024 11:48
Base automatically changed from updateIntl4x to main May 28, 2024 11:58
Copy link

github-actions bot commented May 28, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
messages_shrinker Non-Breaking 0.2.2-wip 0.2.2-wip 0.2.2-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/messages_shrinker/lib/messages_shrinker.dart 💚 90 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ⚠️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/messages/examples_flutter/my_application/lib/src/empty_de.dart
pkgs/messages/examples_flutter/my_application/lib/src/empty_en.dart

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@dart-lang dart-lang deleted a comment from github-actions bot Jul 29, 2024
@mosuem mosuem changed the title Adapt the example in package:messages to use AssetBundle Adapt package:messages to use dart:asset Jul 29, 2024
@mosuem mosuem changed the title Adapt package:messages to use dart:asset Adapt package:messages to be loading mechanism independent Oct 22, 2024
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts -

pkgs/messages/example/.gitignore Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
pkgs/messages/pubspec.yaml Outdated Show resolved Hide resolved
.github/workflows/messages.yml Show resolved Hide resolved
@mosuem mosuem marked this pull request as ready for review October 23, 2024 08:20
@mosuem mosuem merged commit 3820422 into main Oct 31, 2024
16 checks passed
@mosuem mosuem deleted the adaptMessagesExample branch October 31, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants