-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt package:messages
to be loading mechanism independent
#843
Conversation
f5a0922
to
dc27228
Compare
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers
|
Files |
---|
pkgs/messages/examples_flutter/my_application/lib/src/empty_de.dart |
pkgs/messages/examples_flutter/my_application/lib/src/empty_en.dart |
All source files should start with a license header.
This check can be disabled by tagging the PR with skip-license-check
.
9a4d6ca
to
433d40d
Compare
433d40d
to
38ac02d
Compare
38ac02d
to
1dc22c0
Compare
package:messages
to use AssetBundle
package:messages
to use dart:asset
package:messages
to use dart:asset
package:messages
to be loading mechanism independent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few thoughts -
build_runner
in favor ofdart run messages
dart:asset
zero
not being parsed)Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.