Measure how memory is consumed by a test. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Aug 21, 2023
pkgs/leak_tracker/test/tests/leak_tracking/end_to_end_test.dart
Outdated
Show resolved
Hide resolved
| Widget _materialApp({int seed = 0}) => MaterialApp( | ||
| home: SizedBox( | ||
| height: | ||
| 10 + seed % 101, // We need some change to avoid constant values. |
There was a problem hiding this comment.
Do we need this modulo operation here? seed is in [0, 9], so this won't ever do anything.
There was a problem hiding this comment.
The method is not aware about seed size, and in future it may change. So, leaving as is.
bkonyi
reviewed
Aug 21, 2023
| samples: 249 - 249 = 0 | ||
|
|
||
| To set as new baseline, set parameter of MemoryBaselining: | ||
| baseline: MemoryBaseline( |
There was a problem hiding this comment.
Is there any possible way that we can include the Dart SDK version in the MemoryBaseline data? That way we can explicitly print a warning if a baseline from an older SDK is being used with a newer SDK.
There was a problem hiding this comment.
I think we need this issue to be resolved: flutter/flutter#61814
Added comment.
bkonyi
approved these changes
Aug 23, 2023
pkgs/leak_tracker/lib/src/leak_tracking/_primitives/_print_bytes.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results for unit test in leak_tracker: