Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image handling instructions. #250

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update image handling instructions. #250

merged 3 commits into from
Oct 21, 2024

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c requested a review from bkonyi October 21, 2024 19:37
@polina-c polina-c changed the title Update image handling. Update image handling instructions. Oct 21, 2024
@@ -258,5 +258,6 @@ Images in Flutter have an unusual lifecycle:
2. The setting `.withIgnored(createdByTestHelpers: true)` does not work for images, because
creation of their native part is not detectable as happening in a test helper.

3. Images are cashed and reused that improves test performance. So, `tearDownAll(imageCache.clear)`
will help if leaks are caused by test code.
3. Images are cashed and reused that improves test performance. And, `tearDownAll(imageCache.clear)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/cashed/cached/ here and below

@polina-c polina-c merged commit be75122 into main Oct 21, 2024
3 checks passed
@polina-c polina-c deleted the polina-c-patch-2 branch October 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants