Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create troubleshooting helpers. #89

Merged
merged 23 commits into from
Jul 11, 2023
Merged

Create troubleshooting helpers. #89

merged 23 commits into from
Jul 11, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c marked this pull request as ready for review July 11, 2023 02:20
@polina-c polina-c requested a review from CoderDake as a code owner July 11, 2023 02:20
## Verify object references

If you expect an object to be not referenced at some point,
but tot sure, you can validate it by temporary adding assertion:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
but tot sure, you can validate it by temporary adding assertion:
but not sure, you can validate it by temporarily adding assertion:

/// Verifies that garbage collection happened using [reachabilityBarrier].
/// Does not work in web and in release mode.
///
/// Use [timeout] to limit waitning time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: waiting

/// Use [timeout] to limit waitning time.
/// Use [fullGcCycles] to force multiple garbage collections.
///
/// The methot is useable for testing in combination with [WeakReference] to ensure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "method is used"

@polina-c polina-c changed the title Create troubleshooting helpers Create troubleshooting helpers. Jul 11, 2023
@polina-c polina-c merged commit 8e3aa07 into dart-lang:main Jul 11, 2023
2 checks passed
@polina-c polina-c deleted the helpers branch July 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants