Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test cover case of customized gcCountBuffer #99

Merged
merged 10 commits into from
Jul 21, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c marked this pull request as ready for review July 20, 2023 21:59
@polina-c polina-c requested a review from CoderDake as a code owner July 20, 2023 21:59
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments related to the changelog and over-ridding the main dart-lang/ contributing.md file (note also the test failures).

CONTRIBUTING.md Outdated Show resolved Hide resolved
pkgs/leak_tracker/CHANGELOG.md Outdated Show resolved Hide resolved
@polina-c polina-c requested a review from devoncarew July 21, 2023 17:12
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@polina-c polina-c merged commit 6e3f57c into dart-lang:main Jul 21, 2023
2 checks passed
@polina-c polina-c deleted the fix-gccount branch July 21, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants