Enable lints to use new language features (#3987)

analysis_options.yaml

@@ -23,6 +23,7 @@ linter:
     - avoid_unused_constructor_parameters
     - avoid_void_async
     - cancel_subscriptions
+    - dangling_library_doc_comments
     - directives_ordering
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
@@ -41,6 +42,9 @@ linter:
     - type_annotate_public_apis
     - unawaited_futures
     - unnecessary_lambdas
+    - unnecessary_library_directive
     - unnecessary_null_aware_assignments
     - unnecessary_parenthesis
     - unnecessary_statements
+    - use_enums
+    - use_super_parameters

lib/src/ascii_tree.dart

@@ -4,6 +4,8 @@
 
 /// A simple library for rendering tree-like structures in Unicode symbols with
 /// a fallback to ASCII.
+library;
+
 import 'dart:io';
 
 import 'package:path/path.dart' as path;

lib/src/command/dependency_services.dart

@@ -2,8 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-/// This implements support for dependency-bot style automated upgrades.
+/// Implements support for dependency-bot style automated upgrades.
 /// It is still work in progress - do not rely on the current output.
+library;
+
 import 'dart:convert';
 import 'dart:io';
 

lib/src/dart.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// A library for compiling Dart code and manipulating analyzer parse trees.
+library;
+
 import 'dart:async';
 import 'dart:io';
 

lib/src/exceptions.dart

@@ -30,7 +30,7 @@ class ApplicationException implements Exception {
 /// A subclass of [ApplicationException] that occurs when running a subprocess
 /// has failed.
 class RunProcessException extends ApplicationException {
-  RunProcessException(String message) : super(message);
+  RunProcessException(super.message);
 }
 
 /// An exception class for exceptions that are intended to be seen by the user
@@ -56,9 +56,8 @@ class WrappedException extends ApplicationException {
   /// The stack chain for [innerError] if it exists.
   final Chain? innerChain;
 
-  WrappedException(String message, this.innerError, [StackTrace? innerTrace])
-      : innerChain = innerTrace == null ? null : Chain.forTrace(innerTrace),
-        super(message);
+  WrappedException(super.message, this.innerError, [StackTrace? innerTrace])
+      : innerChain = innerTrace == null ? null : Chain.forTrace(innerTrace);
 }
 
 /// A class for exceptions that shouldn't be printed at the top level.
@@ -74,14 +73,14 @@ class SilentException extends WrappedException {
 ///
 /// This corresponds to the `data` exit code.
 class DataException extends ApplicationException {
-  DataException(String message) : super(message);
+  DataException(super.message);
 }
 
 /// An exception indicating that the users configuration is invalid.
 ///
 /// This corresponds to the `config` exit code;
 class ConfigException extends ApplicationException {
-  ConfigException(String message) : super(message);
+  ConfigException(super.message);
 }
 
 /// An class for exceptions where a package could not be found in a [Source].
@@ -108,8 +107,7 @@ class PackageNotFoundException extends WrappedException {
 
 /// A class for exceptions where a package's checksum could not be validated.
 class PackageIntegrityException extends PubHttpException {
-  PackageIntegrityException(String message)
-      : super(message, isIntermittent: true);
+  PackageIntegrityException(super.message) : super(isIntermittent: true);
 }
 
 /// Returns whether [error] is a user-facing error object.
@@ -141,11 +139,11 @@ class SourceSpanApplicationException extends SourceSpanFormatException
   final String? hint;
 
   SourceSpanApplicationException(
-    String message,
-    SourceSpan? span, {
+    super.message,
+    super.span, {
     this.hint,
     this.explanation,
-  }) : super(message, span);
+  });
 
   @override
   String toString({Object? color}) {

lib/src/git.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality for invoking Git.
+library;
+
 import 'dart:async';
 
 import 'package:collection/collection.dart';

lib/src/http.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helpers for dealing with HTTP.
+library;
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

lib/src/ignore.dart

@@ -25,6 +25,8 @@
 /// [Ignore.listFiles].
 ///
 /// [1]: https://git-scm.com/docs/gitignore
+library;
+
 import 'package:meta/meta.dart';
 
 /// A set of ignore rules representing a single ignore file.

lib/src/io.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper functionality to make working with IO easier.
+library;
+
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';

lib/src/isolate.dart

@@ -3,11 +3,13 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// A library for utility functions for dealing with isolates.
+library;
+
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
 
-/// Like [Isolate.spanwUri], except that this only returns once the Isolate has
+/// Like [Isolate.spawnUri], except that this only returns once the Isolate has
 /// exited.
 ///
 /// If the isolate produces an unhandled exception, it's printed to stderr and

lib/src/log.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Message logging.
+library;
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
@@ -60,36 +62,36 @@ final _bold = getAnsi('\u001b[1m');
 /// An enum type for defining the different logging levels a given message can
 /// be associated with.
 ///
-/// By default, [error] and [warning] messages are printed to sterr. [message]
-/// messages are printed to stdout, and others are ignored.
-class Level {
+/// By default, [error] and [warning] messages are printed to stderr.
+/// [message] messages are printed to stdout, and others are ignored.
+enum Level {
   /// An error occurred and an operation could not be completed.
   ///
   /// Usually shown to the user on stderr.
-  static const error = Level._('ERR ');
+  error('ERR '),
 
   /// Something unexpected happened, but the program was able to continue,
   /// though possibly in a degraded fashion.
-  static const warning = Level._('WARN');
+  warning('WARN'),
 
   /// A message intended specifically to be shown to the user.
-  static const message = Level._('MSG ');
+  message('MSG '),
 
   /// Some interaction with the external world occurred, such as a network
   /// operation, process spawning, or file IO.
-  static const io = Level._('IO  ');
+  io('IO  '),
 
   /// Incremental output during pub's version constraint solver.
-  static const solver = Level._('SLVR');
+  solver('SLVR'),
 
   /// Fine-grained and verbose additional information.
   ///
   /// Used to provide program state context for other logs (such as what pub
   /// was doing when an IO operation occurred) or just more detail for an
   /// operation.
-  static const fine = Level._('FINE');
+  fine('FINE');
 
-  const Level._(this.name);
+  const Level(this.name);
 
   final String name;
 
@@ -99,79 +101,79 @@ class Level {
 
 /// An enum type to control which log levels are displayed and how they are
 /// displayed.
-class Verbosity {
+enum Verbosity {
   /// Silence all logging.
-  static const none = Verbosity._('none', {
+  none('none', {
     Level.error: null,
     Level.warning: null,
     Level.message: null,
     Level.io: null,
     Level.solver: null,
     Level.fine: null,
-  });
+  }),
 
   /// Shows only errors.
-  static const error = Verbosity._('error', {
+  error('error', {
     Level.error: _logToStderr,
     Level.warning: null,
     Level.message: null,
     Level.io: null,
     Level.solver: null,
     Level.fine: null,
-  });
+  }),
 
   /// Shows only errors and warnings.
-  static const warning = Verbosity._('warning', {
+  warning('warning', {
     Level.error: _logToStderr,
     Level.warning: _logToStderr,
     Level.message: null,
     Level.io: null,
     Level.solver: null,
     Level.fine: null,
-  });
+  }),
 
   /// The default verbosity which shows errors, warnings, and messages.
-  static const normal = Verbosity._('normal', {
+  normal('normal', {
     Level.error: _logToStderr,
     Level.warning: _logToStderr,
     Level.message: _logToStdout,
     Level.io: null,
     Level.solver: null,
     Level.fine: null,
-  });
+  }),
 
   /// Shows errors, warnings, messages, and IO event logs.
-  static const io = Verbosity._('io', {
+  io('io', {
     Level.error: _logToStderrWithLabel,
     Level.warning: _logToStderrWithLabel,
     Level.message: _logToStdoutWithLabel,
     Level.io: _logToStderrWithLabel,
     Level.solver: null,
     Level.fine: null,
-  });
+  }),
 
   /// Shows errors, warnings, messages, and version solver logs.
-  static const solver = Verbosity._('solver', {
+  solver('solver', {
     Level.error: _logToStderr,
     Level.warning: _logToStderr,
     Level.message: _logToStdout,
     Level.io: null,
     Level.solver: _logToStdout,
     Level.fine: null,
-  });
+  }),
 
   /// Shows all logs.
-  static const all = Verbosity._('all', {
+  all('all', {
     Level.error: _logToStderrWithLabel,
     Level.warning: _logToStderrWithLabel,
     Level.message: _logToStdoutWithLabel,
     Level.io: _logToStderrWithLabel,
     Level.solver: _logToStderrWithLabel,
     Level.fine: _logToStderrWithLabel,
-  });
+  }),
 
   /// Shows all logs.
-  static const testing = Verbosity._('testing', {
+  testing('testing', {
     Level.error: _logToStderrWithLabel,
     Level.warning: _logToStderrWithLabel,
     Level.message: _logToStdoutWithLabel,
@@ -180,7 +182,7 @@ class Verbosity {
     Level.fine: _logToStderrWithLabel,
   });
 
-  const Verbosity._(this.name, this._loggers);
+  const Verbosity(this.name, this._loggers);
 
   final String name;
   final Map<Level, void Function(_Entry entry)?> _loggers;
@@ -409,7 +411,7 @@ Platform: ${Platform.operatingSystem}
 
 /// Filter out normal pub output when not attached to a terminal
 ///
-/// Unless the user has overriden the verbosity,
+/// Unless the user has overridden the verbosity,
 ///
 /// This is useful to not pollute stdout when the output is piped somewhere.
 Future<T> errorsOnlyUnlessTerminal<T>(FutureOr<T> Function() callback) async {

lib/src/solver/assignment.dart

@@ -30,10 +30,10 @@ class Assignment extends Term {
   /// Creates a derivation: an assignment that's automatically propagated from
   /// incompatibilities.
   Assignment.derivation(
-    PackageRange package,
-    bool isPositive,
+    super.package,
+    super.isPositive,
     this.cause,
     this.decisionLevel,
     this.index,
-  ) : super(package, isPositive);
+  );
 }

lib/src/solver/set_relation.dart

@@ -3,24 +3,24 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// An enum of possible relationships between two sets.
-class SetRelation {
+enum SetRelation {
   /// The second set contains all elements of the first, as well as possibly
   /// more.
-  static const subset = SetRelation._('subset');
+  subset('subset'),
 
   /// Neither set contains any elements of the other.
-  static const disjoint = SetRelation._('disjoint');
+  disjoint('disjoint'),
 
   /// The sets have elements in common, but the first is not a superset of the
   /// second.
   ///
   /// This is also used when the first set is a superset of the first, but in
   /// practice we don't need to distinguish that from overlapping sets.
-  static const overlapping = SetRelation._('overlapping');
+  overlapping('overlapping');
 
   final String _name;
 
-  const SetRelation._(this._name);
+  const SetRelation(this._name);
 
   @override
   String toString() => _name;