Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and increase flexibility of language version override test #3985

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix and increase flexibility of language version override test #3985

merged 1 commit into from
Aug 14, 2023

Conversation

parlough
Copy link
Member

No description provided.

sigurdm
sigurdm approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks!

For mosts tests we use the _PUB_TEST_SDK_VERSION variable, but here it is the analyzer that doesn't pick it up.

I guess this is the best we can do.

@sigurdm sigurdm merged commit 6c26764 into dart-lang:master Aug 14, 2023
23 checks passed
@parlough parlough deleted the fix/language-version-test branch August 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @sigurdm