Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline needed parts of package oauth2 #4009

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Inline needed parts of package oauth2 #4009

merged 2 commits into from
Sep 7, 2023

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 5, 2023

  • copy-pasted everything from package:oauth2 into lib/src/oauth.dart
  • made everything not exported private.
  • deleted a few unused functions
  • added trailing commas
  • converted a class-based enum to a real enum.

Further simplifications can be done as follow-ups...

@sigurdm sigurdm requested a review from jonasfj September 5, 2023 13:42
jonasfj
jonasfj approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there is a lot of opportunity to delete things like _onCredentialsRefreshed 🚀

@sigurdm sigurdm merged commit 588ff5d into dart-lang:master Sep 7, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdm @jonasfj