Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't impose a strict size limit to uploads #4014

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Don't impose a strict size limit to uploads #4014

merged 4 commits into from
Sep 15, 2023

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 13, 2023

Fix of: #4013

szakarias
szakarias approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm
Copy link
Contributor Author

sigurdm commented Sep 14, 2023

When testing uploads of too large packages, the error message was not descriptive. So I added a poor person's parsing of the error messages from GCS.

PTAL.

jonasfj
jonasfj approved these changes Sep 15, 2023
View reviewed changes
lib/src/http.dart Outdated Show resolved Hide resolved
test/lish/cloud_storage_upload_provides_an_error_test.dart Show resolved Hide resolved
sigurdm and others added 2 commits September 15, 2023 10:33
@sigurdm @jonasfj
Update lib/src/http.dart
1080528 
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
@sigurdm
Add TODO
f365e83
@sigurdm sigurdm merged commit 2bb8e2c into dart-lang:master Sep 15, 2023
23 checks passed
@sigurdm sigurdm mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@szakarias szakarias Awaiting requested review from szakarias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigurdm @jonasfj @szakarias