Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation version number without build part #4056

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix calculation version number without build part #4056

merged 1 commit into from
Nov 27, 2023

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Nov 21, 2023 •
edited
Loading

Fixes: #4051
When there was no prerelease component, we would produce an empty-string prerelease component instead of null.

szakarias
szakarias approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm sigurdm merged commit 061cac8 into dart-lang:master Nov 27, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szakarias szakarias szakarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing doesn't consider x.y.z+1 to be an incremental update from x.y.z
2 participants
@sigurdm @szakarias