have the analyze portion of publishing validation only analyze bin/ and lib/

[devoncarew]

• have the analyze portion of publishing validation only analyze bin/ and lib/
• separately, remove lints that are duplicative of package:lints/recommended.yaml

Having the validation step analyze code can be pretty problematic with publishing automation. This preserves the validation static analysis, but scopes it to the portion of a package that's consumed by clients - lib/ and bin/ (removing test/).

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[devoncarew]

Thanks!

[dcharkes]

Drive by comment. So build.dart toplevel script isn't analyzed currently.

[sigurdm]

Drive by comment. So build.dart toplevel script isn't analyzed currently.

Right, should it be?

[dcharkes]

Drive by comment. So build.dart toplevel script isn't analyzed currently.

Right, should it be?

It's being invoked from other packages to build native assets. So unlike tools/ and test/ it's code used when a package is used as a dependency.

(And so will link.dart be once it's introduced.)

Do we maintain a definitive list of files/directories that is part of the "used as a dependency" somewhere that I can add these things? (Having the list just in lib/src/validator/analyze.dart seems a bit specific, and there will likely be more than one copy in that case?)

[sigurdm]

Do we maintain a definitive list of files/directories that is part of the "used as a dependency"

No I don't think we do, the closest is the validator/analyze.dart file that defines what files we analyze on publication.