Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor test shards #4069

Merged
merged 1 commit into from
Dec 4, 2023
Merged

refactor test shards #4069

merged 1 commit into from
Dec 4, 2023

Conversation

devoncarew
Copy link
Member

  • update the test sharding logic to use the dart test --total-shards and --shard-index cli args

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@sigurdm
Copy link
Contributor

sigurdm commented Dec 4, 2023

Just for historical context, this didn't work before dart-lang/test#1452 was solved.

Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sigurdm sigurdm merged commit 92cd5a1 into master Dec 4, 2023
23 checks passed
@sigurdm sigurdm deleted the shards branch December 4, 2023 09:00
@devoncarew
Copy link
Member Author

Just for historical context, this didn't work before dart-lang/test#1452 was solved.

Ah, cool. Yeah, I saw the bash sharding config in the workflow file and assumed it pre-dated the dart test sharding support. I sent this PR to see if things would generally work using that built-in support - it makes the workflow file a bit simplier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants