Skip to content

Commit

Permalink
Skip SDK library-level expression evaluation tests
Browse files Browse the repository at this point in the history
These are no longer handled with the new module format,
so skip them when that's enabled. This is the last piece
to get expression evaluation tests working again with the
new format.

Change-Id: I92933363ea4e275f7a3f1c9cd62e24b0f7987f49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393162
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
  • Loading branch information
srujzs authored and Commit Queue committed Nov 5, 2024
1 parent 4fa616b commit 1d4c570
Showing 1 changed file with 18 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -489,14 +489,30 @@ void runNullSafeSharedTests(
expression: 'Flow.begin(id: 0) is Flow',
libraryUri: Uri.parse('dart:developer'),
expectedResult: 'true');
});
},
// The new module format requires a per-library compiler. Since we
// loaded the SDK from a summary/dill, we've never actually created a
// compiler for it, and therefore can't execute library-level
// expression evaluation in the SDK. Currently, no real workflow can
// meaningfully use this anyways. See
// https://github.com/flutter/devtools/issues/7766 for the initial
// motivation.
skip: setup.emitLibraryBundle);

test('tearoff an SDK method', () async {
await driver.check(
expression: 'postEvent',
libraryUri: Uri.parse('dart:developer'),
expectedResult: contains('function postEvent(eventKind'));
});
},
// The new module format requires a per-library compiler. Since we
// loaded the SDK from a summary/dill, we've never actually created a
// compiler for it, and therefore can't execute library-level
// expression evaluation in the SDK. Currently, no real workflow can
// meaningfully use this anyways. See
// https://github.com/flutter/devtools/issues/7766 for the initial
// motivation.
skip: setup.emitLibraryBundle);
});

group('method level', () {
Expand Down

0 comments on commit 1d4c570

Please sign in to comment.