Fix root suite comparison on Windows #2038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2037
Canonicalize paths when checking whether a stack frame is coming from
the test suite root.
Add a test case which runs with an absolute path argument. On windows,
this situation would have resulted in the
root_
location informationbeing missing because of a difference in the stack frame paths and the
suite path before canonicalization. This test fails on windows without
the canonicalization.
Make the test utils more flexible to handle the new output differences
across operation systems.
Allow a
Matcher
value for thepath
argument tosuiteJson
. Thisoptional argument had previously been unused. Use
equalsIgnoreCase
because on windows there is a difference in the case of the drive
letter.
Allow a
Matcher
value for thename
argument totestStartJson
. Takean
Object
to allow eitherMatcher
orString
for existing uses.Check the "loading" output line loosely by checking only the start and
end.