Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root suite comparison on Windows #2038

Merged
merged 8 commits into from
Jun 16, 2023
Merged

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented Jun 15, 2023

Fixes #2037

Canonicalize paths when checking whether a stack frame is coming from
the test suite root.

Add a test case which runs with an absolute path argument. On windows,
this situation would have resulted in the root_ location information
being missing because of a difference in the stack frame paths and the
suite path before canonicalization. This test fails on windows without
the canonicalization.

Make the test utils more flexible to handle the new output differences
across operation systems.
Allow a Matcher value for the path argument to suiteJson. This
optional argument had previously been unused. Use equalsIgnoreCase
because on windows there is a difference in the case of the drive
letter.
Allow a Matcher value for the name argument to testStartJson. Take
an Object to allow either Matcher or String for existing uses.
Check the "loading" output line loosely by checking only the start and
end.

@natebosch natebosch requested a review from jakemac53 June 16, 2023 00:49
@natebosch natebosch marked this pull request as ready for review June 16, 2023 00:49
@natebosch natebosch changed the title Add a test for root_line with aboslute test path Fix root suite comparison on Windows Jun 16, 2023
@natebosch natebosch merged commit 3d5afed into master Jun 16, 2023
31 checks passed
@natebosch natebosch deleted the missing-windows-root-line branch June 16, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test url/line/col are missing in JSON output on Windows
2 participants