Improve weight checker

Signed-off-by: Xavier Lau <xavier@inv.cafe>

Cargo.toml

@@ -17,7 +17,7 @@ edition    = "2021"
 homepage   = "https://darwinia.network"
 license    = "GPL-3.0"
 repository = "https://github.com/darwinia-network/darwinia"
-version    = "6.3.4"
+version    = "6.4.0"
 
 [workspace.dependencies]
 # crates.io

runtime/crab/src/migration.rs

@@ -41,7 +41,18 @@ impl frame_support::traits::OnRuntimeUpgrade for CustomOnRuntimeUpgrade {
 }
 
 fn migrate() -> frame_support::weights::Weight {
-	frame_support::weights::Weight::zero()
+	// substrate
+	use frame_support::traits::StorageVersion;
+
+	// Some pallets ere added on chain after the migration.
+	// Thus, they never required the migration and we just missed to set the correct
+	// `StorageVersion`.
+	StorageVersion::new(4).put::<Scheduler>();
+	StorageVersion::new(3).put::<XcmpQueue>();
+	StorageVersion::new(1).put::<PolkadotXcm>();
+	StorageVersion::new(2).put::<DmpQueue>();
+
+	// frame_support::weights::Weight::zero()
 	// RuntimeBlockWeights::get().max_block
-	// <Runtime as frame_system::Config>::DbWeight::get().reads_writes(0, 0)
+	<Runtime as frame_system::Config>::DbWeight::get().reads_writes(0, 4)
 }

tool/weight-checker/src/main.rs

@@ -4,6 +4,9 @@ use std::{fs, path::PathBuf};
 use clap::Parser;
 use regex::Regex;
 
+const ON_CHAIN_REF_TIME: u128 = 349_900_160_000;
+const ON_CHAIN_PROOF_SIZE: u128 = 3_670_016;
+
 fn main() {
 	let Cli { paths } = Cli::parse();
 
@@ -14,26 +17,29 @@ fn main() {
 			panic!("invalid path");
 		}
 
-		let (on_chain_ref_time, on_chain_proof_size) = (349_900_160_000, 3_670_016);
-		let (mut ref_time, mut proof_size) = (0, 0);
+		println!("Max on-chain   `ref_time`: {ON_CHAIN_REF_TIME}");
+		println!("Max on-chain `proof_size`: {ON_CHAIN_PROOF_SIZE}");
+
+		let mut problems = Vec::new();
 
 		fs::read_dir(p).unwrap().for_each(|e| {
 			let e = e.unwrap();
 			let p = e.path();
-			let t = fs::read_to_string(p).unwrap();
-			let (ref_time_, proof_size_) = R::new().captures_max(&t);
+			let t = fs::read_to_string(&p).unwrap();
+			let (ref_time, proof_size) = R::new().captures_max(&t);
 
-			ref_time = ref_time.max(ref_time_);
-			proof_size = proof_size.max(proof_size_);
+			if ref_time >= ON_CHAIN_REF_TIME || proof_size >= ON_CHAIN_PROOF_SIZE {
+				problems.push((ref_time, proof_size, p.display().to_string()));
+			}
 		});
 
-		println!("Max            `ref_time`: {ref_time}");
-		println!("Max on-chain   `ref_time`: {on_chain_ref_time}");
-		println!("Max          `proof_size`: {proof_size}");
-		println!("Max on-chain `proof_size`: {on_chain_proof_size}");
-
-		if ref_time >= on_chain_ref_time || proof_size >= on_chain_proof_size {
-			panic!("exceeded on-chain limit");
+		if !problems.is_empty() {
+			panic!(
+				"{}",
+				problems.into_iter().fold(String::new(), |acc, (t, ps, p)| format!(
+					"{acc}ref_time({t}) proof_size({ps}) path({p})\n"
+				))
+			);
 		}
 	});
 }