Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the enable-background attribute #65

Closed
wants to merge 1 commit into from

Conversation

Bersman
Copy link

@Bersman Bersman commented Sep 3, 2021

PR for #63

@xerc
Copy link
Contributor

xerc commented Nov 16, 2021

@ohader
Copy link
Contributor

ohader commented Nov 16, 2021

deprecated ; https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/enable-background

Sure, but still being used in the wild. It's similar to xlink:href which still is used even it is deprecated (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href).

@brianteeman
Copy link
Contributor

Please merge this

@darylldoyle
Copy link
Owner

The enable-background attribute has been deprecated from the SVG specification for some time. It only seems to be included in Illustrator exports now for some legacy reason. If it's not being actively used in the SVG (which I assume it's not) then I see no problem removing it. As such I'd rather not add support for it. If support is needed for the attribute, I suggest extending the AllowedAttributes class and using the setAllowedAttrs method on the sanitiser to pass them in prior to running it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants