Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add up-to-date documentation and remove legacy documentation (DEV-4229) #263

Merged
merged 5 commits into from
Oct 11, 2024
Merged

docs: Add up-to-date documentation and remove legacy documentation (DEV-4229) #263

merged 5 commits into from
Oct 11, 2024

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Oct 9, 2024 •
edited
Loading

This PR:

  • removes the old documentation moved over from the old dsp-meta-svc repo, which was
    • partially entirely obsolete (examples, RDF-renderings, etc.)
    • partially outdated
  • adds some new documentation, which should be up to date, and easier to keep updated in case of future changes

@BalduinLandolt BalduinLandolt self-assigned this Oct 9, 2024
@linear Linear
Copy link

linear bot commented Oct 9, 2024

DEV-4229 Update Documentation of Current Metadata

@BalduinLandolt BalduinLandolt marked this pull request as ready for review October 9, 2024 13:37
seakayone
seakayone approved these changes Oct 10, 2024
View reviewed changes
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
mpro7
mpro7 approved these changes Oct 11, 2024
View reviewed changes
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
docs/data/datamodel.md Outdated Show resolved Hide resolved
BalduinLandolt and others added 2 commits October 11, 2024 20:40
@BalduinLandolt @mpro7 @seakayone
Apply suggestions from code review
ca718ca 
Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
Co-authored-by: Christian Kleinbölting <seakayone@users.noreply.github.com>
@BalduinLandolt
apply more review feedback
b131222
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) October 11, 2024 18:49
@BalduinLandolt BalduinLandolt merged commit 88b2234 into main Oct 11, 2024
18 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-4229-update-documentation-of-current-metadata branch October 11, 2024 18:52
@daschbot daschbot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@seakayone seakayone seakayone approved these changes

@subotic subotic Awaiting requested review from subotic

@danielasubotic danielasubotic Awaiting requested review from danielasubotic

@siers siers Awaiting requested review from siers siers is a code owner

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalduinLandolt @seakayone @mpro7