refactor(upload-files): stream big files (DEV-4469) #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnussbaum
changed the title
seakayone
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
(nitpick) This is not a pure refactoring, you are changing the behaviour by changing the timeout value.
Generally I would appreciate a short description of the motiviation of the refactoring. My comment on merging the two try blocks might miss the context of your motivation and could be void.
Now after having reviewed this PR I think the central change in this PR is that the binaray_io is directly supported by requests. This looks good to me and my comment on the try block is void.
jnussbaum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.