-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added simple boot sector analyzer #6
base: master
Are you sure you want to change the base?
Conversation
Hey, cool! Here some first thoughts about the code: Some small code style related things that definitively should be changed before we merge something:
But I have some questions too:
And one last suggestion:
|
Yeah that is possible to be integrated, there already is a bootsector struct and you can get a struct of the main bootsector from the And about a checksum field in the bootsector: It does theoretically have a checksum field, but I read something about it not being used, so I did just check and the value of the checksum field is indeed 0 . |
I added a method that returns a struct of the bootsector copy to the NTFS class now. |
Merge branch 'master' into ntfs-meta
Any suggestions how/if we continue on this? As @timbuntu said, it might be easier to just read original bootsector and its copy and do a simple == comparison. As comparing 512 bytes for a one time check is not very resource intensive. But you put some effort into this feature and I think this should be visible in the final submission. But I don't really know how we should do this if this piece of code will not be in our master... Suggestions welcome :) |
this program can (1) check if the boot sector was compromised (by creating and comparing hash values with the backup boot sector at the end) and (2) scans and (currently) prints it onto the console.
issues: