Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update release process document to follow-up v20 release #5710

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

knst
Copy link
Collaborator

@knst knst commented Nov 16, 2023

Issue being fixed or feature implemented

Our Release Process document is not exactly matched with our template issue that created by copy-paste from previous release.

For the next release just copy test from this document to new issue

What was done?

Release Process document is updated to match with our real release process.
This document has also detailed instructions for many steps (in compare to the issue that we use now which is more checklist) to make releasing process easier for all participant.

How Has This Been Tested?

Tested on air by 2 last released: v19, v20: #5694

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20.1 milestone Nov 16, 2023
@knst
Copy link
Collaborator Author

knst commented Nov 16, 2023

Link to preview how this MD file is rendered by GitHub: https://github.com/dashpay/dash/blob/ed9d86e9805e93a05fe6b81a2acb764e34b9ffb5/doc/release-process.md

@knst knst changed the title doc: update release process document to follow-up v20 release docs: update release process document to follow-up v20 release Nov 16, 2023
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
that causes rejection of blocks in the past history.
* [ ] Ensure that governance is functional after sentinel changes are done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed moving forward

Suggested change
* [ ] Ensure that governance is functional after sentinel changes are done

Comment on lines 113 to 117
* [ ] Pasta Guix Build
* [ ] UdjinM6 Guix Build
* [ ] Thephez Guix Build
* [ ] kwvg Guix Build
* [ ] knst Guix Build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not enumerating these here as this can change from version to version

Comment on lines 171 to 175
* [ ] Pasta
* [ ] UdjinM6
* [ ] Thephez
* [ ] kwvg
* [ ] knst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested updates and corrections...

doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
doc/release-process.md Outdated Show resolved Hide resolved
@knst knst requested a review from thephez November 20, 2023 14:59
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating this 👍

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see UdjinM6@1038c1a for some suggestions

@knst knst requested a review from UdjinM6 November 21, 2023 13:50
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 91f1584 into dashpay:develop Nov 29, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants