-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: implement
shape_touched
optimisation (#381)
* scaffolding * separation of data and shape touched * checkpoint * wip * wip: latest * refactor: drop reference to reports * wip * wip * fix: don't try to read root column * fix: support fallback case * fix: support typetracing sample * test: fix tests * fix: don't touch data buffers for sizes Originally, if we saw a non-metadata buffer, we'd look to see if the current node has any unknown-length attributes that need computing. But, only NumpyArray has `data`, and it has no unknown-length attributes to read. * chore: appease pre-commit * chore: remove debug statement * feat!: remove `necessary_buffers` * chore: add type hints * fix: properly "deep" copy forms * fix: typo Co-authored-by: Doug Davis <ddavis@ddavis.io> * test: drop local changes * fix: correct LSP * docs: add docstring * refactor: separate mocking from projection more cleanly * feat: return reports for later consumption * feat: expose `dak.report_necessary_buffers` * fix: ensure we only check input layers * feat: make default buffer key nicer * fix: restore ability to detect serialised blockwise layers * fix: remove `_meta` when serialising IO function * test: restore original test file * docs: use new name for necessary_columns * fix: restore wildcard projection for column-at-a-time readers * refactor: use DFS to find deepest field * fix: remove old code * refactor: remove two-phase abstraction * docs: add brief comment * test: add note about broken test * feat: add `necessary_columns` interface * feat: add `necessary_columns` interface * docs: improve notes * refactor: add implementation for mixin * docs: add note about `report_necessary_buffers` * fix: support `dak.necessary_columns` * refactor: export utils * chore: require newer uproot * chore: add local test file * chore: bump awkward depndency * Update docs/api/inspect.rst --------- Co-authored-by: Doug Davis <ddavis@anaconda.com> Co-authored-by: Doug Davis <ddavis@ddavis.io>
- Loading branch information
1 parent
5981337
commit 96b19df
Showing
29 changed files
with
996 additions
and
693 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.