Use np.int64 type for day to nanosecond conversion (NEP50) #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like its time to ditch the dask CI run, since they have deprecated fastparquet as an engine and apparently broken a load of stuff. |
|
Thanks for fixing this, by the way :). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921.
Fixes #923 (after release)
Required due to a change in numpy's type promotion with numpy >= 2:
https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
NEP 50 -- Promotion rules for Python scalars
The
DAYS_TO_MILLISconstant actually contained the number of nanoseconds in a day, so I renamed it. I hope this is not incorrectly used outside of fastparquet. At least it is not part of the API documentation.