-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring extract_geo_features #2704
refactoring extract_geo_features #2704
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #2704 +/- ##
==========================================
- Coverage 53.22% 52.77% -0.46%
==========================================
Files 119 122 +3
Lines 9924 10108 +184
==========================================
+ Hits 5282 5334 +52
- Misses 4642 4774 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
if newsflash.resolution in [ | ||
BE_CONST.ResolutionCategories.STREET, | ||
BE_CONST.ResolutionCategories.SUBURBAN_ROAD, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using SUPPORTED_RESOLUTIONS
It consists of ResolutionCategories.SUBURBAN_JUNCTION, but that's ok since it will be a supported soon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done
…ctor-extract-geo-features
No description provided.