Vulnerability fix : Exclude the transitive dependency org.apache.ivy:ivy from hydrator-test #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency hydrator-test.
vsethi09
requested changes
Dec 14, 2022
| @@ -127,6 +127,10 @@ | |||
| <groupId>com.fasterxml.jackson.core</groupId> | |||
| <artifactId>jackson-databind</artifactId> | |||
| </exclusion> | |||
| <exclusion> | |||
There was a problem hiding this comment.
The org.apache.ivy:ivy transitive dependency is present in org.apache.spark:spark-core_2.11 dependency of io.cdap.cdap:cdap-spark-core2_2.11 module. Ideally the transitive dependency should be excluded from direct dependency in CDAP's cdap-spark-core2_2.11 module. (link)
This would ensure that the vulnerability is fixed at all places.
Output of mvn dependency:tree -Dincludes='org.apache.ivy:ivy':
[INFO] \- io.cdap.cdap:hydrator-test:jar:6.9.0-SNAPSHOT:provided
[INFO] \- io.cdap.cdap:cdap-unit-test:jar:6.9.0-SNAPSHOT:provided
[INFO] \- io.cdap.cdap:cdap-spark-core2_2.11:jar:6.9.0-SNAPSHOT:provided
[INFO] \- org.apache.spark:spark-core_2.11:jar:2.1.3:provided
[INFO] \- org.apache.ivy:ivy:jar:2.4.0:provided
[INFO] ------------------------------------------------------
There was a problem hiding this comment.
I think this is ok assuming we don't have any tests that use this functionality. However, we might not be able to exclude this dependency from io.cdap.cdap:cdap-spark-core2_2.11 entirely because there could be users who use the Advanced Dependency Management feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluded the ivy dependency as affected versions of this package are vulnerable to Directory Traversal in the 'IvyPatternHelper' class.
[INFO] io.cdap.plugin:amazon-s3-plugins:jar:1.19.0-SNAPSHOT
[INFO] - io.cdap.cdap:hydrator-test:jar:6.9.0-SNAPSHOT:provided
[INFO] - io.cdap.cdap:cdap-unit-test:jar:6.9.0-SNAPSHOT:provided
[INFO] - io.cdap.cdap:cdap-spark-core2_2.11:jar:6.9.0-SNAPSHOT:provided
[INFO] - org.apache.spark:spark-core_2.11:jar:2.1.3:provided
[INFO] - org.apache.ivy:ivy:jar:2.4.0:provided