e2e_oracle replication tests #121
Conversation
| When Enter input plugin property: "name" with pipelineName | ||
| And Click on the "Next" button in replication to navigate | ||
| And Select Source plugin: "Oracle" from the replication plugins list | ||
| Then Select radio button plugin property: "connectivityMethod" with value: "private-connectivity" |
There was a problem hiding this comment.
Nit: Use camel case for variable 'private-connectivity'
There was a problem hiding this comment.
It is the value to be selected.
| Then Replace input plugin property: "port" with value: "oraclePort" for Credentials and Authorization related fields | ||
| Then Replace input plugin property: "sid" with value: "oracleDatabaseName" | ||
| Then Replace input plugin property: "user" with value: "oracleUsername" for Credentials and Authorization related fields | ||
| Then Click on the Macro button of Property: "password" and set the value to: "Password" |
There was a problem hiding this comment.
Nit: 'Password' -> 'oraclePassword' like in other cases
| Then Close the replication pipeline logs and stop the pipeline | ||
|
|
||
| @ORACLE_SOURCE_TEST @ORACLE_DELETE_TEST @BIGQUERY_DELETE @Required |
There was a problem hiding this comment.
shouldn't this be in caps as well?
There was a problem hiding this comment.
Changed to caps.
| Assert.assertNotNull(logs); | ||
| PageHelper.closeCurrentWindow(); | ||
| return logs; | ||
| ElementHelper.clickOnElement(CdfPluginPropertiesLocators.selectReplicationTable(table),300); | ||
| } | ||
|
|
||
| public static void waitTillPipelineIsRunningAndCheckForErrors() throws InterruptedException { | ||
| //wait for datastream to startup | ||
| int defaultTimeout = Integer.parseInt(PluginPropertyUtils.pluginProp("pipeline-initialization")); |
There was a problem hiding this comment.
Nit: variable in camelCase
| oracleUsername=ORACLE_USERNAME | ||
| oraclePassword=ORACLE_PASSWORD | ||
| privateConnectionName=ghsubnet | ||
|
|
| } | ||
|
|
||
| public static void verifyTargetBigQueryRecordMatchesExpectedOracleRecord() | ||
| throws IOException, InterruptedException, SQLException, ClassNotFoundException { | ||
| // Checking if an error message is displayed. | ||
| Assert.assertFalse(ElementHelper.isElementDisplayed(ReplicationLocators.error)); | ||
|
|
There was a problem hiding this comment.
nit:remove this blank line
| Assert.assertNotNull(logs); | ||
| PageHelper.closeCurrentWindow(); | ||
| return logs; | ||
| ElementHelper.clickOnElement(CdfPluginPropertiesLocators.selectReplicationTable(table),300); |
There was a problem hiding this comment.
nit: wait time can be shorter here, I think 180 seconds should be good enough.what do you think?
There was a problem hiding this comment.
Yes, changed to 180 seconds.
| public void captureRawLogs() { | ||
| ReplicationActions.captureRawLog(); | ||
| } | ||
|
|
||
| @And("Run insert, update and delete CDC events on source table") |
There was a problem hiding this comment.
except for this, all are common steps that are used in all sources.Can you place in common stepsdesign?
There was a problem hiding this comment.
Here, we need the schema name, database name which differ for source plugins table creation and are mentioned and used from pluginParameter file for pipeline initialization. All the other common replication steps are already placed and used from cdap e2e. https://docs.google.com/document/d/1MXdQujYAzmBmZBGxrCjGPRHbAuhzOT3TXR9DOoqLRGA/edit?resourcekey=0-JpDyJhg4BnXXhMJ8fNF7dw
itsmekumari
force-pushed
the
e2e_Oracle
branch
5 times, most recently
from
37aa7dc
to
43d940e
Compare
itsmekumari
force-pushed
the
e2e_Oracle
branch
2 times, most recently
from
1f0c944
to
da8e1b2
Compare
itsmekumari
force-pushed
the
e2e_Oracle
branch
from
da8e1b2
to
2a9a57b
Compare
e2e_oracle replication tests