Make docs clearer #109
Merged
Make docs clearer #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyu89
reviewed
Oct 25, 2023
| @@ -80,6 +80,7 @@ to get service principal tokens for staging and prod workspace and follow [Encry | |||
| to add the secrets to GitHub: | |||
| - `STAGING_WORKSPACE_TOKEN` : service principal token for staging workspace | |||
| - `PROD_WORKSPACE_TOKEN` : service principal token for prod workspace | |||
| Be sure to update the [Workflow Permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token) section under Repo Settings > Actions > General to allow `Read and write permissions`. | |||
There was a problem hiding this comment.
Is the permission for adding the comment in PR from a github action?
There was a problem hiding this comment.
Yup, I guess we could also just remove that comment step
There was a problem hiding this comment.
That's fine. Before we decide to remove it, the doc is helpful.
mingyu89
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sections to indicate which permissions service principals should have on UC schemas, as well as enabling read & write access for GitHub workflows.