Transpile snow flake select statement #1203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
changed the base branch from
main
to
drop-PlanParser-dependency-on-antlr4-
ericvergnaud
commented
Nov 13, 2024
|
|
||
| /** | ||
| * Returns true if this expression and all its children have been resolved to a specific schema and false if it still | ||
| * contains any unresolved placeholders. Implementations of LogicalPlan can override this (e.g.[[UnresolvedRelation]] | ||
| * should return `false`). | ||
| */ | ||
| lazy val resolved: Boolean = expressions.forall(_.resolved) && childrenResolved | ||
| var comments: Array[CommentNode] = Array() |
There was a problem hiding this comment.
to be discussed, mutating a node at parse time is no big deal, alternately we could insert comment nodes before first child (or after depending on context), but that also requires mutating the tree
jimidle
reviewed
Nov 14, 2024
Indeed but feasability can only be proven by feasing... Now we know what can be done, and we have evidence of which problems are introduced |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
borrows technical idea from #1208, but applies it to a new field, thus avoiding any backwards compatibility issue.
Adds a test for checking transpilation of SnowFlake select statement, and fixes issues
Requires #1201
Progresses #869
Supersedes #1193