Refactor transpile error for LSP #1382
Open
+142
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiplexer/display-lsp-diagnositics-in-console * feature/multiplexer/transpile-using-lsp: formatting fix failing tests formatting # Conflicts: # src/databricks/labs/remorph/transpiler/execute.py
ericvergnaud
changed the base branch from
main
to
feature/multiplexer/transpile-using-lsp
ericvergnaud
changed the title
…anspile * main: Simplify transpiler api (#1361) # Conflicts: # src/databricks/labs/remorph/config.py # src/databricks/labs/remorph/transpiler/execute.py # src/databricks/labs/remorph/transpiler/lsp/lsp_engine.py # src/databricks/labs/remorph/transpiler/sqlglot/sqlglot_engine.py # src/databricks/labs/remorph/transpiler/transpile_engine.py
…to feature/multiplexer/refactor-transpile-error * feature/multiplexer/perform-checks-within-transpile: fix merge issues Simplify transpiler api (#1361)
…ultiplexer/refactor-transpile-error * feature/multiplexer/transpile-using-lsp: Perform checks during transpile (#1364) # Conflicts: # src/databricks/labs/remorph/transpiler/execute.py # src/databricks/labs/remorph/transpiler/sqlglot/sqlglot_engine.py
…ultiplexer/refactor-transpile-error * feature/multiplexer/transpile-using-lsp: formatting # Conflicts: # src/databricks/labs/remorph/transpiler/execute.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of transpile errors relies on error types i.e.
ParseErrorandValidationError.This will not work with LSP because LSP cannot convey such class hierarchy, rather it conveys flat structures named
Diagnostics.This PR aligns our implementation with LSP
Diagnosticsby:ParseErrorandValidationErrorin favor of their base classTranspileErrorThis is in preparation of #1301