Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display LSP diagnostics in console #1385

Draft
wants to merge 8 commits into
base: feature/multiplexer/refactor-transpile-error
Choose a base branch
from

Conversation

ericvergnaud
Copy link
Contributor

Our current implementation ignores LSP diagnostics.
Also it stores transpile errors in the target directory, but does not display them in the console.
This PR:

  • converts LSP diagnostics into TranspileErrors
  • displays them in the console

Fixes #1301

@ericvergnaud ericvergnaud requested a review from a team as a code owner December 20, 2024 14:30
@ericvergnaud ericvergnaud changed the base branch from main to feature/multiplexer/transpile-using-lsp December 20, 2024 14:32
Copy link

github-actions bot commented Dec 20, 2024

Coverage tests results

506 tests  ±0   468 ✅ ±0   5s ⏱️ ±0s
  7 suites ±0    38 💤 ±0 
  7 files   ±0     0 ❌ ±0 

Results for commit 6875600. ± Comparison against base commit 6564429.

♻️ This comment has been updated with latest results.

@ericvergnaud ericvergnaud marked this pull request as draft December 20, 2024 14:38
@ericvergnaud ericvergnaud changed the base branch from feature/multiplexer/transpile-using-lsp to feature/multiplexer/refactor-transpile-error December 20, 2024 15:42
…ure/multiplexer/display-lsp-diagnositics-in-console

* feature/multiplexer/refactor-transpile-error:
  Create launcher from cli (#1315)
  fix issue where unit tests would create files not ignored by git (#1381)

# Conflicts:
#	tests/unit/test_cli_transpile.py
…ure/multiplexer/display-lsp-diagnositics-in-console

* feature/multiplexer/refactor-transpile-error:
  fix merge issues
  Simplify transpiler api (#1361)
…ure/multiplexer/display-lsp-diagnositics-in-console

* feature/multiplexer/refactor-transpile-error:
  formatting
  Perform checks during transpile (#1364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Multiplexer - display transpile errors in the CLI
1 participant