-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to address bioconductor lesson issues from first beta #167
Conversation
@ytakemon @JasonJWilliamsNY @poterlowicz-lab This is now ready for review when you have a moment. Thanks! |
@@ -21,17 +21,24 @@ source("../bin/chunk-options.R") | |||
knitr_fig_path("04-") | |||
``` | |||
|
|||
<!-- example of rendered lesson https://datacarpentry.org/genomics-r-intro/02-r-basics/index.html --> | |||
## Packages in R -- what are they and why do we use them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this explanation! I noticed that we mention packages in the "R Basics continued" episode, but we don't explain it to this extent. I wonder if this would be a better fit in an earlier episode than in the Bioconductor one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think that probably makes sense. This is related to #170 -- if @JasonJWilliamsNY is ok with it I can pull this description out from here, and do a PR of the content on the R Basic continued lesson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Merging.
The rest of the commits look great @naupaka! I'd be happy to merge this request once we had a chance to discuss my comment above. |
Thanks to @naupaka for addressing the mega issue related to the Bioconductor section!
This is a PR to address issues raised in the first beta-pilot of the lesson (outlined in #142). All of the commits address problems identified in the bioconductor lesson.
It addresses: